Serialize all responses used in the NEST Server #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
terhorstd
added
S: Normal
nicolossus
approved these changes
Aug 15, 2023
babsey
force-pushed
the
nest-server-serializable
branch
from
5a92324
to
6de167b
Compare
jougs
reviewed
Aug 29, 2023
There was a problem hiding this comment.
The changes in this PR look good to me.
Just one thing that always bothered me: Why is the function called serializable()? From a function with that name I would expect that it returns a Boolean flag indicating if the argument can be serialized or not. But this function actually serializes its argument and consequently should rather be called serialize()? Shouldn't it?
Or am I missing something essential here?
|
Is |
|
Much better in my opinion! |
jougs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shows a usecase that
NodeCollectionor other NEST objects are stored inuserdict.Then the user wants to get
userdictvia API-requests.Example:
It produces server error because the data in
userdictcannot be transformed for JSON when they areNodeCollectionor other NEST objects.