Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the registration of recording and stimulation backends #2640

Merged
merged 8 commits into from
Mar 15, 2023

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Mar 14, 2023

This is a rather unsorted collection of changes related to the registration of recording and stimulation backends in preparation of the module system refactoring.

nestkernel/exceptions.h Show resolved Hide resolved
nestkernel/io_manager.cpp Show resolved Hide resolved
nestkernel/io_manager.cpp Outdated Show resolved Hide resolved
nestkernel/io_manager.cpp Show resolved Hide resolved
nestkernel/io_manager_impl.h Show resolved Hide resolved
Co-authored-by: med-ayssar <med.ayssar@gmail.com>
@JanVogelsang
Copy link
Contributor

JanVogelsang commented Mar 14, 2023

@jougs Something went wrong in your last commit, the lines are duplicated now.

nestkernel/io_manager.cpp Outdated Show resolved Hide resolved
@jougs
Copy link
Contributor Author

jougs commented Mar 15, 2023

@JanVogelsang: I removed the duplicated lines. Also thanks for your other input.
@med-ayssar: I think I have addressed all your points. Can you please re-review? Thanks!

Copy link
Contributor

@med-ayssar med-ayssar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now!

@jougs jougs merged commit 55ee309 into nest:master Mar 15, 2023
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants