Make helper libraries static and don't install the archive files #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougs
added
S: Normal
med-ayssar
approved these changes
Apr 11, 2023
JanVogelsang
approved these changes
Apr 11, 2023
jougs
changed the title
jougs
commented
Apr 12, 2023
There was a problem hiding this comment.
After checking the changes in #2250 again, I am pretty sure, we don't need the VERSION ${NEST_VERSION} lines anymore now that the libraries are static. @sanjayankur31, feel free to contradict me -- either here or in a follow-up issue or pull request.
Sorry---been away on leave. Yes, versioning is only required for the ones that are being included as shared objects. Bits that are internal static libs don't need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1182 by making
libmodels,libnestutilandlibnestkernelstatic libraries that are directly included wherever they are needed. As these are only internal helper libraries, there is no need to install them.The remaining libraries
libnest,libsliandlibsli_readlinewill be taken care of by the PyNEST NG project.@sanjayankur31: I assume that with these changes, also the
VERSION ${NEST_VERSION}line could go away, can't it?