Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NEST Server Client from nest-simulator repository #2656

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Apr 7, 2023

This PR removes the NEST Server Client from the nest-simulator main repository. The code has already been resurrected under the name NEST Client in the repository https://github.com/nest/nest-client.

@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: External API Developers of extensions or other language bindings may need to adapt their code labels Apr 7, 2023
@jougs jougs requested review from babsey and pnbabu April 7, 2023 14:32
@jougs jougs self-assigned this Apr 7, 2023
Copy link
Contributor

@babsey babsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added small suggestion.

doc/htmldoc/connect_nest/nest_server.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have one minor comment.

doc/htmldoc/connect_nest/nest_server.rst Outdated Show resolved Hide resolved
jougs and others added 2 commits April 12, 2023 22:09
Co-authored-by: Sebastian Spreizer <spreizer@web.de>
Co-authored-by: Pooja Babu <75320801+pnbabu@users.noreply.github.com>
@jougs
Copy link
Contributor Author

jougs commented Apr 12, 2023

@pnbabu: I take your "Looks good to me" as an approval and merge. Thanks for reviewing so quickly :-)

@jougs jougs merged commit 114bb1b into nest:master Apr 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: External API Developers of extensions or other language bindings may need to adapt their code S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants