Revise some spatial tests to pytest style; avoids numercial issues due to float comparisons #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precise float comparions
heplesser
added
T: Bug
nicolossus
approved these changes
Apr 11, 2023
med-ayssar
suggested changes
Apr 11, 2023
There was a problem hiding this comment.
Most of the tests in test_SynapseCollection_distance might be split into 3 parts:
- Using Grid
- Using Free distribution (include randomness)
- Mixed: Both variants
Each of those has the same pattern:
- Create Nodes
- Connect
- GetConnections
- Get distance
- assert
So I think we can have one function for each of the three variants mentioned above and use pytest decorators to parametrize the function to avoid code repetition.
testsuite/pytests/test_spatial/test_SynapseCollection_distance.py
Outdated
Show resolved
Hide resolved
@heplesser: Otherwise regarding the bug, the changes look fine. If you want to consider my suggestions, I will wait and approve later, otherwise if you think that they should belong to a different PR, then I will approve immediately. |
Co-authored-by: med-ayssar <med.ayssar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this PR is that tests from two modules failed on Apple silicon after upgrading to macOS 13.3.1 and XCode 14.3 because some distance values returned by NEST differ in the last decimal (mantissa bit). The difference occurs with Apple Clang 14.0.3 and GCC 12.2.0; it does not occur on Intel silicon.
All comparisons (except where exact zero is expected) now use
pytest.approx(). The tests are also restructured in PyTest form and grouped in two classes according to the network setup they require.The tests could probably be revised further, but this is a bug fix and should therefore not be delayed.