Make it an error to set multiple threads if NEST was built without thread support #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread support; skip tests depending on threading.
heplesser
added
S: Normal
|
Apart from the formatting issues, the changes look good to me! |
JanVogelsang
approved these changes
Apr 11, 2023
med-ayssar
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
I was just randomly checking some interesting PRs.
@jougs, if you don't mind, I can review it instead of you :D
@heplesser: It looks good!
|
@med-ayssar Thanks! @jougs Since it (minimally) changes behaviour (some scripts will fail now), I'd appreciate your input as well. |
jougs
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, setting more than one thread if NEST was built without thread support resulted only in a warning. This led to a considerable number of tests being run in a meaningless way, and potentially causing problems in MPI-based test.
This PR makes it an error to try to set more that one local thread if NEST was built without thread support. The PR also ensures that all tests requiring multiple threads are skipped.