Catch all exceptions in SimulationManager::update_() #2677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SimulationManager::update_()
, exceptions in a thread-parallel context are caught and buffered, to be re-thrown later outside of the parallel context. However, the try..catch block involved only wrapped theNode::update()
call, not any of the other code inSimulationManager::update_()
.This came up because the following line should be "fail_butnocrash_or_die"; the "hard failure" (exception not handled; SLI interpreter process terminates) was not being caught by the test:
nest-simulator/testsuite/unittests/test_binary.sli
Line 170 in 0888491
This PR moves the try..catch block one level higher so it wraps all code in
SimulationManager::update_()
.