Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exceptions in SimulationManager::update_() #2677

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

clinssen
Copy link
Contributor

In SimulationManager::update_(), exceptions in a thread-parallel context are caught and buffered, to be re-thrown later outside of the parallel context. However, the try..catch block involved only wrapped the Node::update() call, not any of the other code in SimulationManager::update_().

This came up because the following line should be "fail_butnocrash_or_die"; the "hard failure" (exception not handled; SLI interpreter process terminates) was not being caught by the test:

This PR moves the try..catch block one level higher so it wraps all code in SimulationManager::update_().

@clinssen clinssen added T: Bug Wrong statements in the code or documentation ZC: Kernel DO NOT USE THIS LABEL S: High Should be handled next labels Apr 24, 2023
@clinssen clinssen requested a review from heplesser April 24, 2023 13:37
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for fixing.

@jougs jougs merged commit 0efb61e into nest:master Apr 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: High Should be handled next T: Bug Wrong statements in the code or documentation ZC: Kernel DO NOT USE THIS LABEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants