Fix setting min and max delay after resolution change #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlober
added a commit
to mlober/nest-simulator
that referenced
this pull request
Apr 26, 2023
heplesser
approved these changes
Apr 26, 2023
terhorstd
added
T: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in adjusting the minimum and maximum delay after a change in resolution.
When the new resolution exceeds the precision of the minimum and maximum delay, the minimum delay should be rounded down, while the maximum delay should be rounded up.
However, in the case of changing the resolution after setting the minimum and maximum delays in a separate call, the minimum delay was always rounded up instead of down. This is now fixed.
Since I added information about the rounding procedure in the case of a resolution change to the documentation, I suggest @jessica-mitchell as one of the reviewers.