Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure VP number, RNG type and RNG seed can be set in any order #2704

Merged
merged 12 commits into from
Apr 27, 2023
Merged

Ensure VP number, RNG type and RNG seed can be set in any order #2704

merged 12 commits into from
Apr 27, 2023

Conversation

heplesser
Copy link
Contributor

This PR ensures that VP number, RNG type and RNG seed can be set in any order. Also converts ticket-754.sli to Pytest and extends it to catch previously uncaught cases.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Apr 26, 2023
@heplesser heplesser added this to PRs in progress in Kernel via automation Apr 26, 2023
@heplesser heplesser requested review from nicolossus and removed request for diesmann April 27, 2023 08:22
jougs
jougs requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good. I just would make some variables class constants to have them defined centrally and unclutter the actual code

testsuite/pytests/sli2py_regressions/ticket_754.py Show resolved Hide resolved
testsuite/pytests/sli2py_regressions/ticket_754.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_regressions/ticket_754.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_regressions/ticket_754.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_regressions/ticket_754.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_regressions/ticket_754.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_regressions/ticket_754.py Show resolved Hide resolved
Kernel automation moved this from PRs in progress to PRs pending approval Apr 27, 2023
jougs
jougs approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jougs jougs merged commit 73a1e21 into nest:master Apr 27, 2023
1 check passed
Kernel automation moved this from PRs pending approval to Done (PRs and issues) Apr 27, 2023
@heplesser heplesser deleted the fix_seeding_and_proc_setting branch September 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@nicolossus nicolossus nicolossus approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @jougs @nicolossus