Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -lnest to the list of libraries to link extension modules #2718

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Add -lnest to the list of libraries to link extension modules #2718

merged 1 commit into from
Apr 27, 2023

Conversation

pnbabu
Copy link
Contributor

@pnbabu pnbabu commented Apr 27, 2023

The build for nest-extension-module fails for MacOS with a link error because the libnest is missing in the list of libraries to link for extension modules. Adding the -lnest option resolves the error.

@pnbabu pnbabu requested review from jougs and heplesser April 27, 2023 09:54
jougs
jougs reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jougs jougs merged commit e3930e8 into nest:master Apr 27, 2023
6 checks passed
@terhorstd terhorstd added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pnbabu @heplesser @jougs @terhorstd