Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installation of PyNEST egg-info and dependencies from setup.py #2728

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Apr 27, 2023

This undoes the installation of egg-info from the CMake configuration file of PyNEST as it was never properly working and is now starting to break even more on newer installations of Python.

This also fixes #2300 by removing the attempted unconditional installation of PyNEST's dependencies. See also #2058.

@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Apr 27, 2023
@jougs jougs requested review from Helveg and clinssen April 27, 2023 14:01
@jougs jougs self-assigned this Apr 27, 2023
@jougs jougs added this to To do in Installation via automation Apr 27, 2023
@jougs jougs added this to To do in Build system and CI via automation Apr 27, 2023
@clinssen clinssen merged commit c311873 into nest:master Apr 28, 2023
6 checks passed
Installation automation moved this from To do to Done Apr 28, 2023
Build system and CI automation moved this from To do to Done Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Installation
  
Done
Development

Successfully merging this pull request may close these issues.

make install unconditionally tries to install python dependencies via pip
3 participants