Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the documentation requirements to prevent incompatible dependencies #2744

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Pin the documentation requirements to prevent incompatible dependencies #2744

merged 2 commits into from
Apr 28, 2023

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Apr 28, 2023

RTD supports max Python 3.8, and ipython just released a new version that is incompatible with it, causing the doc builds to fail. I pinned all the doc/requirements.txt to exact versions to prevent this in the future, and pinned the ipython version to 8.11, the last version compatible with python 3.8

@jougs jougs requested review from steffengraber and removed request for jessica-mitchell April 28, 2023 13:24
jougs
jougs approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! RtD builds seem to work again with this in place.

@jougs jougs removed the request for review from steffengraber April 28, 2023 13:25
@jougs jougs merged commit 836447d into nest:master Apr 28, 2023
1 check passed
@Helveg Helveg deleted the fix-rtd branch April 28, 2023 13:27
@terhorstd terhorstd added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Helveg @jougs @terhorstd