Port test_multiple_multimeter from SLI-2-Py
#2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: testsuite/pytests/sli2py_recording/test_multimeter_freeze_thaw.py testsuite/pytests/test_multimeter.py
nicolossus
added
S: Normal
heplesser
requested changes
Aug 28, 2023
testsuite/pytests/sli2py_recording/test_multimeter_freeze_thaw.py
Outdated
Show resolved
Hide resolved
heplesser
reviewed
Aug 29, 2023
Conflicts: testsuite/pytests/test_multimeter.py
heplesser
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is a bit messy, partly due to our new auto-formatter. I have ported the tests from
test_multiple_multimeter.sliintotest_multimeter.py. One test needed a subset of the models with recordables, which necessitated definingskip_modelsandextra_params. We should be able to remove most of this clutter when we add more complex model extraction directly from PyNEST in the future.Also, due to the theme of
test_multimeter_freeze(), I relocated it fromtest_multimeter.pytotest_multimeter_freeze_thaw.py.