Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port test-set-start-stop-origin.sli from Sli-2-Py #2757

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Port test-set-start-stop-origin.sli from Sli-2-Py #2757

merged 5 commits into from
Nov 28, 2023

Conversation

med-ayssar
Copy link
Contributor

No description provided.

nicolossus
nicolossus suggested changes May 15, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, but I think some documentation should be added to the tests. See suggestions.

testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_set_start_stop_origin.py Outdated Show resolved Hide resolved
@heplesser
Copy link
Contributor

@med-ayssar Remember to merge master to activate black-testing.

@nicolossus nicolossus added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 24, 2023
@nicolossus nicolossus self-requested a review August 24, 2023 13:32
@heplesser
Copy link
Contributor

Resolved conversations as @nicolossus who had raised the issues has approved the PR. Ready to merge.

@heplesser heplesser changed the title Transpile test-set-start-stop-origin.sli Port test-set-start-stop-origin.sli from Sli-2-Py Nov 28, 2023
@heplesser heplesser merged commit ac59615 into nest:master Nov 28, 2023
20 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolossus nicolossus nicolossus approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@med-ayssar @heplesser @nicolossus