Refactor SLI test for spike generator to Python #2761
Conversation
There was a problem hiding this comment.
@pnbabu Thanks, this looks good overall. I've made some suggestions for making the test code a bit more compact and formatted according to the Black formatter.
The SLI versions of these tests have some documentation; can you please also add docstrings with a short descriptions for each test?
|
@pnbabu Ping from the NEST Testing meeting! |
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
|
@pnbabu Ping! |
I have applied the suggestions from the code review. I will request a review again. |
There was a problem hiding this comment.
@pnbabu Thanks! This now looks mostly good to me, but can you also add the documentation from the SLI version as docstrings describing a bit more what each test actually checks?
There was a problem hiding this comment.
@pnbabu Thanks! I have a few nitpicks but once they are addressed I will be happy :)
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
terhorstd
added
S: Normal
No description provided.