Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the debian/ folder #2776

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Remove the debian/ folder #2776

merged 2 commits into from
Jun 19, 2023

Conversation

steffengraber
Copy link
Contributor

The debian/ folder and the files inside are used to build debian packages.
Since the contents are not maintained and not needed for building the NEST Ubuntu PPA package, the complete folder can be deleted.

@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Jun 2, 2023
@jessica-mitchell jessica-mitchell added this to To do in Installation via automation Jun 2, 2023
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 2, 2023
@steffengraber
Copy link
Contributor Author

Hi @sanjayankur31 , as a packaging expert, could you please review this pull request? Is the content of this folder somehow needed in your workflow?

@sanjayankur31
Copy link
Contributor

If these aren't being used by you folks to generate the debian etc. packages, they can be safely removed. They're not used at all for the Fedora/Red Hat RPM packaging workflow.

@gtrensch gtrensch moved this from To do to Review in Installation Jun 19, 2023
@gtrensch gtrensch assigned gtrensch and unassigned gtrensch Jun 19, 2023
@gtrensch gtrensch self-requested a review June 19, 2023 09:45
@gtrensch
Copy link
Contributor

This also matches the documentation.

@gtrensch gtrensch merged commit 7ee5765 into nest:master Jun 19, 2023
20 checks passed
Documentation automation moved this from In progress to Done Jun 19, 2023
Installation automation moved this from Review to Done Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Installation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants