Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorials in documentation #2780

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

mlober
Copy link
Contributor

@mlober mlober commented May 11, 2023

We (intern Dorothee Germer and I) found a list of things to improve in the tutorials in the nest documentation:

Part 1:

  • in Creating Nodes: I_e must be set to 376. instead of 375. for the neuron to elicit spikes.
  • in Extracting and Plotting Data from Devices: changed the naming of variables for better readability.

Part 2:

  • in Generating Populations of Neurons with Deterministic Connections: multimeters must be connected with the one_to_one rule, otherwise they all record the same 10 neurons, which is redundant.

Part 3:

  • in Parameterizing Synapse Models: command nest.Models() is deprecated. Use command synapse_models instead.

Part 4:

  • in Defining Spatially Distributed Nodes - On Grid: missing comma in code.

We suggest @jessica-mitchell as a reviewer.

Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlober thanks for taking some time to fix up some docs. LGTM :)

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 12, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation May 12, 2023
@jessica-mitchell jessica-mitchell merged commit feea1ca into nest:master May 12, 2023
20 checks passed
Documentation automation moved this from In progress to Done May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants