Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in spatial docs to render code #2781

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Fix typos in spatial docs to render code #2781

merged 4 commits into from
Jun 1, 2023

Conversation

jessica-mitchell
Copy link
Contributor

This PR fixes some typos that prevented the code from rendering in the spatially structured networks docs.

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 12, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation May 12, 2023
@heplesser heplesser requested a review from janskaar May 22, 2023 09:55
@clinssen
Copy link
Contributor

There's still a mix of :end-before: #{ end #} and # { end #} in the rst; could this be made consistent throughout?

@jessica-mitchell
Copy link
Contributor Author

@clinssen or @janskaar can you please take a look, i made the syntax consistent for all code blocks

@jessica-mitchell
Copy link
Contributor Author

@clinssen Can you approve this, and check I've addressed your changes?

@jessica-mitchell jessica-mitchell merged commit 3086b0f into nest:master Jun 1, 2023
19 of 20 checks passed
Documentation automation moved this from In progress to Done Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janskaar janskaar janskaar approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jessica-mitchell @clinssen @janskaar