Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multapses and autapses flags more visible in documentation #2785

Merged
merged 2 commits into from
May 23, 2023

Conversation

clinssen
Copy link
Contributor

The default values for these flags could be confusing to users (at least one, who came to me asking for support on this). This PR makes these flags more visible in the documentation by moving them to their own subsection.

@clinssen clinssen added T: Enhancement New functionality, model or documentation ZC: Documentation DO NOT USE THIS LABEL labels May 13, 2023
@clinssen clinssen added this to In progress in Documentation via automation May 13, 2023
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clinssen I have a minor fix but I will approve since this looks good overall. Thanks!

doc/htmldoc/synapses/connection_management.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@jhnnsnk jhnnsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, the additional comment about multiple Connect calls is really useful.

Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@clinssen clinssen merged commit fb31cb6 into nest:master May 23, 2023
20 checks passed
Documentation automation moved this from In progress to Done May 23, 2023
@terhorstd terhorstd added S: Normal Handle this with default priority and removed ZC: Documentation DO NOT USE THIS LABEL labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants