Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return valid version information also when git is unavailable #2788

Merged
merged 5 commits into from
May 16, 2023
Merged

Return valid version information also when git is unavailable #2788

merged 5 commits into from
May 16, 2023

Conversation

jougs
Copy link
Contributor

@jougs jougs commented May 15, 2023

This fixes the extraction of version information also if git is not a runnable command. The problem was introduced in #2715.

@jougs jougs added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels May 15, 2023
@jougs jougs added this to To do in Build system and CI via automation May 15, 2023
@jougs jougs self-assigned this May 15, 2023
nicolossus
nicolossus approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can confirm that this fixes the build on a JSC HPC system (JUSUF) without git loaded. A local build with git available also works as expected.

@heplesser heplesser merged commit 0af4c21 into nest:master May 16, 2023
20 checks passed
Build system and CI automation moved this from To do to Done May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@nicolossus nicolossus nicolossus approved these changes

Assignees

@jougs jougs

Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jougs @heplesser @nicolossus