Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and fix clickable images in installation instructions #2793

Merged
merged 3 commits into from
May 24, 2023
Merged

Clean up and fix clickable images in installation instructions #2793

merged 3 commits into from
May 24, 2023

Conversation

clinssen
Copy link
Contributor

Fixes my confusion in #2792 about Windows installation instructions.

@clinssen clinssen added the ZC: Documentation DO NOT USE THIS LABEL label May 22, 2023
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) and removed ZC: Documentation DO NOT USE THIS LABEL labels May 24, 2023
jessica-mitchell
jessica-mitchell approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lgtm

@jessica-mitchell
Copy link
Contributor

Merging with 1 reviewer, as its doc related

@jessica-mitchell jessica-mitchell merged commit 363fe8d into nest:master May 24, 2023
20 checks passed
@jessica-mitchell jessica-mitchell mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clinssen @jessica-mitchell