Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vale version and fix CI package index #2798

Merged
merged 4 commits into from
May 23, 2023
Merged

Update vale version and fix CI package index #2798

merged 4 commits into from
May 23, 2023

Conversation

jessica-mitchell
Copy link
Contributor

This PR fixes the vale CI job by adding an apt update and fix to a style syntax error.
It also updates the version of vale to the most recent version.

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels May 23, 2023
@jessica-mitchell jessica-mitchell added this to To do in Build system and CI via automation May 23, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation May 23, 2023
@jessica-mitchell
Copy link
Contributor Author

I just saw #2796 solves the CI problem, I'd still like to do the fixes to vale. @terhorstd what do you think

terhorstd
terhorstd approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, though I'll change the title to also include the vale version update.
👍

@terhorstd terhorstd changed the title Fix failing CI build for vale Update vale version and fix CI package index May 23, 2023
@jessica-mitchell jessica-mitchell merged commit 45970a7 into nest:master May 23, 2023
20 checks passed
Documentation automation moved this from In progress to Done May 23, 2023
Build system and CI automation moved this from To do to Done May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Build system and CI
  
Done
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessica-mitchell @terhorstd