Fixes #281: Topology now skips non-local potential targets correctly #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jougs @hannahbos Could you take a look? |
… multapses are forbidden.
|
@jhnnsnk Can you have a look into this PR? Thank you. |
heplesser
changed the title
|
@heplesser thanks. Looks good to me. |
|
@jhnnsnk Can you have a look into this PR? Thank you. |
| } | ||
| } | ||
| } | ||
|
|
||
| } // namespace nest | ||
|
|
||
| #endif | ||
| #endif |
There was a problem hiding this comment.
Can you please re-add the newline at the end of the file?
|
@heplesser Just tested it, looks good to me. Sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating divergent connections with fixed fan-out, topology would try to connect to targets even if they were not local. This is now fixed.