Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #281: Topology now skips non-local potential targets correctly #282

Merged
merged 4 commits into from May 3, 2016

Conversation

@heplesser
Copy link
Contributor

heplesser commented Mar 18, 2016

When creating divergent connections with fixed fan-out, topology would try to connect to targets even if they were not local. This is now fixed.

@heplesser
Copy link
Contributor Author

heplesser commented Mar 18, 2016

@jougs @hannahbos Could you take a look?

heplesser added 2 commits Mar 24, 2016
… multapses are forbidden.
@tammoippen
Copy link
Contributor

tammoippen commented Apr 18, 2016

@jhnnsnk Can you have a look into this PR? Thank you.

@heplesser heplesser changed the title Fixes #281: Topology does not attempt to proxies for non-local nodes. Fixes #281: Topology now skips non-local potential targets correctly Apr 18, 2016
@hannahbos
Copy link

hannahbos commented Apr 24, 2016

@heplesser thanks. Looks good to me.

@tammoippen
Copy link
Contributor

tammoippen commented Apr 25, 2016

@jhnnsnk Can you have a look into this PR? Thank you.

}
}
}

} // namespace nest

#endif
#endif

This comment has been minimized.

Copy link
@jougs

jougs Apr 25, 2016

Contributor

Can you please re-add the newline at the end of the file?

@jhnnsnk
Copy link
Contributor

jhnnsnk commented May 3, 2016

@heplesser Just tested it, looks good to me. Sorry for the late response.
👍

@heplesser heplesser merged commit f698ae4 into nest:master May 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@heplesser heplesser deleted the heplesser:issue-281 branch May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.