Fixes #281: Topology now skips non-local potential targets correctly #282

Merged
merged 4 commits into from May 3, 2016

Conversation

Projects
None yet
5 participants
@heplesser
Contributor

heplesser commented Mar 18, 2016

When creating divergent connections with fixed fan-out, topology would try to connect to targets even if they were not local. This is now fixed.

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Mar 18, 2016

Contributor

@jougs @hannahbos Could you take a look?

Contributor

heplesser commented Mar 18, 2016

@jougs @hannahbos Could you take a look?

@tammoippen

This comment has been minimized.

Show comment
Hide comment
@tammoippen

tammoippen Apr 18, 2016

Contributor

@jhnnsnk Can you have a look into this PR? Thank you.

Contributor

tammoippen commented Apr 18, 2016

@jhnnsnk Can you have a look into this PR? Thank you.

@heplesser heplesser changed the title from Fixes #281: Topology does not attempt to proxies for non-local nodes. to Fixes #281: Topology now skips non-local potential targets correctly Apr 18, 2016

@hannahbos

This comment has been minimized.

Show comment
Hide comment
@hannahbos

hannahbos Apr 24, 2016

@heplesser thanks. Looks good to me.

hannahbos commented Apr 24, 2016

@heplesser thanks. Looks good to me.

@tammoippen

This comment has been minimized.

Show comment
Hide comment
@tammoippen

tammoippen Apr 25, 2016

Contributor

@jhnnsnk Can you have a look into this PR? Thank you.

Contributor

tammoippen commented Apr 25, 2016

@jhnnsnk Can you have a look into this PR? Thank you.

topology/connection_creator_impl.h
}
}
}
} // namespace nest
-#endif
+#endif

This comment has been minimized.

@jougs

jougs Apr 25, 2016

Contributor

Can you please re-add the newline at the end of the file?

@jougs

jougs Apr 25, 2016

Contributor

Can you please re-add the newline at the end of the file?

@jhnnsnk

This comment has been minimized.

Show comment
Hide comment
@jhnnsnk

jhnnsnk May 3, 2016

Contributor

@heplesser Just tested it, looks good to me. Sorry for the late response.
👍

Contributor

jhnnsnk commented May 3, 2016

@heplesser Just tested it, looks good to me. Sorry for the late response.
👍

@heplesser heplesser merged commit f698ae4 into nest:master May 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:issue-281 branch May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment