Improve test coverage by unconditionally installing mpi4py #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougs
added
S: Normal
clinssen
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some background first: Importing
mpi4pyestablishes an MPI context consisting of a bunch of environment variables. These variables confuse the MPI launcher detection detection mechanism in certain situations. As a workaround, dfcb7b1 made the installation of MPI4Py conditional on the use of MPI for the compilation of NEST.This PR fixes the detection of MPI launcher contexts from within NEST by also checking the number of set MPI processes and undoes the conditional installation of MPI4Py to re-enable the full functionality of
regressiontests/issue-1703.py(which was skipped with the conditional installation in place).I think a single reviewer for sanity checking is sufficient for this PR.