Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ticket-80-175-179.sli to py #2829

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Port ticket-80-175-179.sli to py #2829

merged 10 commits into from
Aug 22, 2023

Conversation

otcathatsya
Copy link
Contributor

No description provided.

@nicolossus nicolossus self-requested a review June 13, 2023 13:33
@nicolossus nicolossus mentioned this pull request Aug 16, 2023
Merged
nicolossus
nicolossus suggested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otcathatsya Thanks for decoding and porting the test. I have created a PR with some suggested improvements.

nicolossus and others added 2 commits August 16, 2023 13:18
nicolossus
nicolossus approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

heplesser
heplesser requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test has a quite different logic from the old one. I will get in touch directly.

@otcathatsya
Copy link
Contributor Author

otcathatsya commented Aug 21, 2023 •
edited

@nicolossus would you mind quickly checking out the changes? Wasn't entirely sure about the simtime

Edit: did not realise I left the method name as test_things 😓

heplesser
heplesser reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks a lot tidier now, but I am uncertain about one point, see below.

testsuite/pytests/sli2py_regressions/test_ticket_80_175_179.py Outdated Show resolved Hide resolved
@heplesser heplesser merged commit add5bc1 into nest:master Aug 22, 2023
20 checks passed
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@nicolossus nicolossus nicolossus approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@otcathatsya @heplesser @nicolossus @terhorstd