Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues in docs that cause Sphinx warnings #2842

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Jun 27, 2023

This PR fixes several typos and broken links and should resolve many Sphinx warnings that happen at build time.
It should resolve all warnings except the ones about the mc images (resolved in PR #2823), index_stimulation backend (discussed in another PR) and nest.spatial (modified in PR #2588).

To resolve the warnings about the HillTononiModels.ipynb, the markdown cells cannot have lines that begin with a space, so these were removed. Did not seem to affect the equations or output in anyway.

In the connection_management file there were duplicate headings which Sphinx didnt like; the markup for the headers was also not correct and needed fixing. The headings under 'Synapse specification' were changed to 'rule: All to all' to distinguish them from the previous section that also had 'All to all' as heading.

The other files had minor typos and broken links.

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 27, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Jun 27, 2023
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jougs jougs merged commit 2d71b8b into nest:master Jun 28, 2023
20 checks passed
Documentation automation moved this from In progress to Done Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants