Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant SLI tests #2845

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Remove redundant SLI tests #2845

merged 3 commits into from
Jul 3, 2023

Conversation

nicolossus
Copy link
Member

@nicolossus nicolossus commented Jun 28, 2023 •
edited

This PR removes old and redundant SLI tests.

@nicolossus nicolossus requested a review from jougs June 28, 2023 09:21
@nicolossus nicolossus changed the title Remove issue-437.sli Remove redundant SLI tests Jun 28, 2023
jougs
jougs approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm merging without second review, as this was discussed in a larger group in an on-site meeting.

@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jul 3, 2023
@jougs jougs merged commit c6d79f7 into nest:master Jul 3, 2023
20 checks passed
@nicolossus nicolossus deleted the remove_issue_437 branch July 3, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolossus @jougs