-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test iaf ps psp accuracy (sli2py) #2873
Test iaf ps psp accuracy (sli2py) #2873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janskaar Good job in deciphering pretty confusing SLI code. I added a few suggestions for even sleeker Python code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better :)! I added two more suggestions. Adding the extra check with grid-based neuron I think rather confuses the test—it is about precise timing. I suggest to take that out again. If you want to tighten the test, I would make more sense to check V_m at several points in time, e.g., the last time step when the effect of the spike is not felt, the first where it should be felt, around the maximum and somewhere in the tail.
No description provided.