Sort and format Python imports and enable isort check in CI
#2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolossus
added
T: Enhancement
nicolossus
commented
Aug 29, 2023
Conflicts: doc/htmldoc/conf.py
heplesser
reviewed
Aug 29, 2023
There was a problem hiding this comment.
@nicolossus This looks neat for many cases and is a huge improvement, but as pointed out inline, but can we get more control about where our own stuff goes? I would like a three-block setup:
- Python Library modules
- Third-party modules
import nestwith all its variants
Is that feasible?
|
@nicolossus Could you update the PR to account for changes in master? |
|
@heplesser Yes, but did we reach a conclusion on where |
Conflicts: pynest/nest/lib/hl_api_spatial.py pynest/nest/lib/hl_api_types.py testsuite/pytests/sli2py_neurons/test_add_freeze_thaw.py testsuite/pytests/sli2py_neurons/test_neurons_handle_multiplicity.py testsuite/pytests/sli2py_recording/test_multimeter_stepping.py testsuite/pytests/test_NodeCollection.py testsuite/pytests/test_multimeter.py testsuite/pytests/test_weight_recorder.py
heplesser
approved these changes
Sep 13, 2023
|
@jessica-mitchell Could you take a look at the changed documentation? |
Conflicts: doc/htmldoc/developer_space/guidelines/coding_guidelines_check.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sorts and formats imports in the Python codebase. The PR also introduces an
isortrunner to the CI and pre-commit.The following files, in particular, should be reviewed closely:
pyproject.toml.pre-commit-config.yml./github/workflows/nestbuildmatrix.ymlIn order to have the
nestimport sorted properly in user facing examples,nestis marked as a known third-party in theisortconfiguration (by defaultisortrecognizes thatnestactually is first-party and will sortimport nestin a separate block at the end of the import section).