Hike minimum required CMake version to 3.19 #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IS_FATAL introduced by nest#2835
heplesser
added
T: Bug
jougs
approved these changes
Aug 10, 2023
It turned out we can use 3.21 on JUSUF, so no problem :). |
JanVogelsang
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2835 took into use CMake function COMMAND_ERROR_IS_FATAL which is only available from CMake 3.19 on (https://github.com/nest/nest-simulator/blob/1a5838eb15321909ffed31de84cfa0b6e048b321/cmake/ProcessOptions.cmake#L664C10-L664C10).
This PR hikes the CMake requirement correspondingly and simplifies the requirement to just a minimum version.
This can cause problems for reproducibility runs on some supercomputers; e.g., JUSUF Stages/2020 supports only CMake 3.18, but is required for use of Python 3.8.