Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NEST favicon to documentation webpage #2886

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add NEST favicon to documentation webpage #2886

merged 2 commits into from
Aug 14, 2023

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Aug 10, 2023 •
edited

This PR adds the same favicon as NEST Desktop. It's a helpful marker for finding the right tab and stands out against the generic Read the Docs icon.

See here for output

@jessica-mitchell jessica-mitchell added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority labels Aug 10, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Aug 10, 2023
terhorstd
terhorstd approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the tabs with NEST documentation are much more findable in my long list of open tabs!
Thanks!!! 👍

@terhorstd
Copy link
Contributor

Minor change, merging with single review.

@terhorstd terhorstd merged commit 850b5e7 into nest:master Aug 14, 2023
20 checks passed
Documentation automation moved this from In progress to Done Aug 14, 2023
@terhorstd terhorstd added the I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessica-mitchell @terhorstd