Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port test_spike_rec_reset from SLI-2-Py #2892

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Port test_spike_rec_reset from SLI-2-Py #2892

merged 2 commits into from
Aug 16, 2023

Conversation

nicolossus
Copy link
Member

No description provided.

heplesser
heplesser requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest slight simplification.

testsuite/pytests/sli2py_recording/test_spike_recorder_reset.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_recording/test_spike_recorder_reset.py Outdated Show resolved Hide resolved
@nicolossus @heplesser
Remove superfluous asserts
b42350a 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@heplesser heplesser merged commit 35dc04b into nest:master Aug 16, 2023
20 checks passed
@nicolossus nicolossus deleted the port_test_spike_rec_reset branch August 16, 2023 09:01
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolossus @heplesser @terhorstd