Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port test_oversize_mask from SLI-2-Py #2904

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

nicolossus
Copy link
Member

No description provided.

Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolossus Thanks for the port! I guess one could have made the test even more compact by parameterizing over all variants for grid and for free respectively on a single test, but we have many tests to port ...

@heplesser heplesser merged commit beafac3 into nest:master Aug 24, 2023
20 checks passed
@nicolossus nicolossus deleted the port_test_oversize_mask branch August 24, 2023 09:07
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants