Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astrocyte_lr_1994 to NEST for the modeling of astrocytes and neuron-astrocyte interactions #2919

Merged
merged 195 commits into from
Sep 15, 2023

Conversation

HanjiaJiang
Copy link
Contributor

We implemented an astrocyte model (astrocyte_lr_1994) based on the paper by Li & Rinzel (1994), for the study of astrocytes and neuron-astrocyte interactions in NEST. A new connection type (sic_connection) and a new neuron type (aeif_cond_alpha_astro) were also implemented for this purpose. We also created two example scripts for astrocyte dynamics, two test files for astrocyte_lr_1994 and sic_connection respectively, and one jupyter notebook file as a reference of model implementation.

The code is co-authored by Jugoslava Aćimović, Jan Hahne, Han-Jia Jiang, Mikko Lehtimäki, Tiina Manninen, and Jonas Stapmanns.

Mikko and others added 30 commits July 13, 2023 14:23
… NEST version. Also add a python example of using the astrocyte component
… when p_astro is not given; assigning or overlapping not possible yet
…astrocytes connecting to neurons without presynaptic sources
… paired with astrocyte" instead of "target neurons paired with astrocyte"; "weight_astro" in syn_spec renamed as "weight_sic"
- True/False for Deterministic/Probabilistic selection of astrocyte pool per target neuron.
- Rename "p_astro" to "p_syn_astro" since this parameter defines the probability of a neuron-neuron synapse being paired with an astrocyte.
- Set default to true
- When true, the default of "max_astro_per_target" is 1
- When false, the default of "max_astro_per_target" is 0 (all astrocytes can connect)
…_per_target_det and (B) max_astro_per_target.

- A=True, B=None: Distribute the neurons according to N_neuron/N_astrocyte.
- A=True, B=n: Make overlapping in uneven cases more balanced (still to be improved).
- Debug: p=1 is OK now, but autapses must be allowed. To be discussed.
…ivity

- Fix the special case of: autapses not allowed, p=1, target overlaps with sources
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

models/astrocyte_lr_1994.cpp Show resolved Hide resolved
nestkernel/nest_names.cpp Outdated Show resolved Hide resolved
@heplesser heplesser removed the request for review from clinssen September 15, 2023 10:10
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks!

Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HanjiaJiang Thank you very much for your efforts in polishing the PR. It is fine now and we can merge as soon as the tests have completed successfully.

@heplesser heplesser merged commit 37c4d37 into nest:master Sep 15, 2023
20 checks passed
Documentation automation moved this from Review to Done Sep 15, 2023
Models automation moved this from Review to Done Sep 15, 2023
@terhorstd terhorstd changed the title Add astrocyte_lr_1994 to NEST for the modeling of astrocytes and neuron-astrocyte interactions Add astrocyte_lr_1994 to NEST for the modeling of astrocytes and neuron-astrocyte interactions Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
Documentation
  
Done
Models
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants