-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sli2py iaf_psc_alpha_multisynapse
#2929
Merged
heplesser
merged 6 commits into
nest:master
from
janskaar:sli2py_iaf_psc_alpha_multisynapse
Oct 20, 2023
Merged
Sli2py iaf_psc_alpha_multisynapse
#2929
heplesser
merged 6 commits into
nest:master
from
janskaar:sli2py_iaf_psc_alpha_multisynapse
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terhorstd
added
S: Normal
Handle this with default priority
T: Maintenance
Work to keep up the quality of the code and documentation.
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
labels
Sep 19, 2023
terhorstd
changed the title
Sli2py iaf psc alpha multisynapse
Sli2py Sep 19, 2023
iaf_psc_alpha_multisynapse
nicolossus
suggested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janskaar Thanks, overall this looks good! I have some minor suggestions for which I have created a PR towards your branch, see janskaar#1.
…napse Suggestions from code review
nicolossus
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: Normal
Handle this with default priority
T: Maintenance
Work to keep up the quality of the code and documentation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.