Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCC compiler problem matcher to CI #2935

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add GCC compiler problem matcher to CI #2935

merged 3 commits into from
Mar 22, 2024

Conversation

nicolossus
Copy link
Member

Resolves #2779.

This PR introduces a GitHub Actions problem matcher which scans the GCC compiler output for a specified regex pattern and surface the information in the UI as annotations.

The problem matcher is identical to the one used in VS Code's cpptools:
https://github.com/microsoft/vscode-cpptools/blob/2cc55ea6ebe96b91c118c84784e980bdfaf20304/Extension/package.json#L303-L320.

@nicolossus nicolossus changed the title Compiler problem matcher Add GCC compiler problem matcher to CI Sep 12, 2023
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 19, 2023
@terhorstd terhorstd added this to To do in Build system and CI via automation Sep 19, 2023
@lekshmideepu lekshmideepu moved this from To do to Review in Build system and CI Sep 21, 2023
@heplesser
Copy link
Contributor

@jougs @terhorstd I think you had already looked at this and expressed support. Could you give formal feedback?

@heplesser heplesser requested review from gtrensch and removed request for jougs November 17, 2023 10:39
terhorstd
terhorstd approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on including this in the CI. The GitHub parsing of stdout magic strings is very irritating, but the changes don't constitute a strong binding to this proprietary service.

@lekshmideepu
Copy link
Contributor

Just a comment: I feel like this is useful. One could may be use this action from the marketplace.

gtrensch
gtrensch approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gtrensch gtrensch merged commit d8bd868 into nest:master Mar 22, 2024
20 checks passed
Build system and CI automation moved this from Review to Done Mar 22, 2024
@nicolossus nicolossus deleted the compiler_problem_matcher branch March 22, 2024 10:20
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the CI fail again when the NEST build raises warnings?
5 participants
@nicolossus @heplesser @lekshmideepu @terhorstd @gtrensch