Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message about OMP_THREAD_NUM on startup #2946

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

heplesser
Copy link
Contributor

This is a follow-up to #2914. It provides an informational message on startup and a warning on setting the thread/VP number. It also tidies up error handling a little.

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 14, 2023
@heplesser heplesser added this to In progress in Kernel via automation Sep 14, 2023
@heplesser
Copy link
Contributor Author

The failing test on macOS will be fixed once #2945 is merged.

Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only have a minor formatting suggestion, see inline comment.

nestkernel/vp_manager.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice clean-up!

@heplesser heplesser merged commit 7de5f09 into nest:master Sep 15, 2023
20 checks passed
Kernel automation moved this from In progress to Done Sep 15, 2023
@heplesser heplesser deleted the fix-omp-threads-warning branch April 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
Kernel
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants