-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message about OMP_THREAD_NUM on startup #2946
Conversation
The failing test on macOS will be fixed once #2945 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only have a minor formatting suggestion, see inline comment.
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice clean-up!
This is a follow-up to #2914. It provides an informational message on startup and a warning on setting the thread/VP number. It also tidies up error handling a little.