Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to some examples #2950

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fixes to some examples #2950

merged 3 commits into from
Sep 22, 2023

Conversation

heplesser
Copy link
Contributor

This PR provides fixes for three examples required due to changes in external packages. It also improves READMEs for two examples.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 20, 2023
@heplesser heplesser added this to In progress in Documentation via automation Sep 20, 2023
@heplesser heplesser mentioned this pull request Sep 20, 2023
Closed
jessica-mitchell
jessica-mitchell approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

steffengraber
steffengraber approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great that you took a closer look at this.

@heplesser heplesser merged commit 64b2f59 into nest:master Sep 22, 2023
21 checks passed
Documentation automation moved this from In progress to Done Sep 22, 2023
@heplesser heplesser deleted the fix-examples branch April 24, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffengraber steffengraber steffengraber approved these changes

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @steffengraber @jessica-mitchell