Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plantuml to docs #2975

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Oct 13, 2023

This PR adds plantuml diagram possibilities to the documentation.

plantuml requires Java so this is installed during build on Read the Docs- This assumes we don't want to add Java as a dependency in our sphinx-build
For local builds, instructions are added to the User documentation workflow on how you can get plantuml diagrams to work.
In addition the requirements for the docs are no longer pinned to a specific version (rather changed to >=), along with version 3.8 of Python being updated to 3.10 in the readthedocs.yml. This didnt seem to break anything and I believe is the more desired way of handling requirements.
There is a temp file showing the output. An actual useful example would be better, so setting as draft for now.

@jessica-mitchell jessica-mitchell marked this pull request as draft October 13, 2023 21:03
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Oct 13, 2023
@jessica-mitchell jessica-mitchell added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 13, 2023
@jessica-mitchell jessica-mitchell marked this pull request as ready for review October 16, 2023 09:37
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. 👍

@jessica-mitchell
Copy link
Contributor Author

Merging with 1 approval, as its docs

@jessica-mitchell jessica-mitchell merged commit d70928e into nest:master Nov 13, 2023
21 checks passed
Documentation automation moved this from In progress to Done Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants