Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models with NMDA dynamics according to Wang (2002) #2979

Open
wants to merge 143 commits into
base: master
Choose a base branch
from

Conversation

janskaar
Copy link
Contributor

@janskaar janskaar commented Oct 30, 2023

Update: Removed draft.

Adds iaf_wang_2002, a model with a conductance based exponential synapse with extra dynamics, from [1]. The model is simplified to allow efficient computation, by taking $t_\mathrm{AMPA,rise} \to 0$ and modelling it as a delta function. Since $t_\mathrm{AMPA,rise} \ll t_\mathrm{AMPA,decay}$, this should not make too much of a difference.

[1] Wang, X. J. (2002). Probabilistic decision making by slow reverberation in cortical circuits. Neuron, 36(5), 955-968.
DOI: https://doi.org/10.1016/S0896-6273(02)01092-9

@janskaar janskaar marked this pull request as draft October 30, 2023 11:26
@janskaar janskaar added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 30, 2023
@heplesser heplesser self-requested a review October 30, 2023 14:10
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janskaar Thanks! Here is my initial review after looking at the implementation of the model.

models/iaf_wang_2002.h Outdated Show resolved Hide resolved
models/iaf_wang_2002.h Outdated Show resolved Hide resolved
models/iaf_wang_2002.h Outdated Show resolved Hide resolved
models/iaf_wang_2002.h Outdated Show resolved Hide resolved
models/iaf_wang_2002.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in the code, we can discuss directly later.

testsuite/pytests/test_iaf_wang_2002.py Outdated Show resolved Hide resolved
testsuite/pytests/test_iaf_wang_2002.py Outdated Show resolved Hide resolved
testsuite/pytests/test_iaf_wang_2002.py Outdated Show resolved Hide resolved
testsuite/pytests/test_iaf_wang_2002.py Outdated Show resolved Hide resolved
testsuite/pytests/test_iaf_wang_2002.py Outdated Show resolved Hide resolved
models/iaf_wang_2002.h Show resolved Hide resolved
models/iaf_wang_2002.h Outdated Show resolved Hide resolved
models/iaf_wang_2002.cpp Outdated Show resolved Hide resolved
models/iaf_wang_2002.cpp Outdated Show resolved Hide resolved
models/iaf_wang_2002.cpp Outdated Show resolved Hide resolved
@heplesser heplesser changed the title Wong wang Add model with NMDA dynamics after Wang (2002) Nov 16, 2023
@heplesser heplesser changed the title Add model with NMDA dynamics after Wang (2002) Add model with NMDA dynamics according to Wang (2002) Apr 29, 2024
@heplesser heplesser changed the title Add model with NMDA dynamics according to Wang (2002) Add models with NMDA dynamics according to Wang (2002) Apr 29, 2024
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little suggestion now, still need to look at examples and tests.

Also consider to rename all _jump variables to _post, see notebook.

models/iaf_wang_2002.cpp Outdated Show resolved Hide resolved
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Models
  
Review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants