-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cleanup of code and comments #2980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jougs! Thanks for these fixes. I agree with most of them, and also with moving register_*
calls out of nestmodule.cpp
. But I think the *_manager
s are not the right place for them: The managers take care of NEST parts, but they do not define which parts NEST has. With the new modelsmodule
, this definition of what is part of NEST wrt neurons and synapses has become nicely separated, and ideally conn-builders and growth rules should be handled correspondingly. I see three options in no particular order and enumerated only for ease of reference:
- Leave the
register_
calls where they are right now until we find a good place for them. - Call
register_conn_
fromconn_builder.cpp
andregister_growth_
fromgrowth_curve.cpp
(provide registers components). - Add the
register_{conn,growth}
calls to the auto-generatedmodelsmodule.cpp
and maybe call thatregister_nest_components.cpp
then.
@heplesser: I agree with all you say. Also, the code does not link properly as it stands. Given the situation I'm in, I'm afraid I won't be able to do anything about this anymore. Please feel free to take the changes, modify the code in whatever way you see fits, or discard them. I just wanted to get these off my chest. |
@jougs If you could reset the |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jougs Thanks!
Minimal code tidying, thus merging based on single review. |
This is stuff that was lying in my cleanup branch and I don't want to be lost. See the list of commits for what and why.