Update clang-format version to 17.0.4 and activate InsertBraces
#2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
S: Normal
jessica-mitchell
approved these changes
Nov 6, 2023
terhorstd
approved these changes
Nov 6, 2023
terhorstd
changed the title
InsertBraces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hikes the clang-format version to 17.0.4, the current version at this point, which is available via PyPi for all relevant OS (https://pypi.org/project/clang-format/#files). It also activates automatic insertion of braces around blocks (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#insertbraces); this feature became available with clang-format 15.
Code format changes due to the transition from 13 to 17 are minimal, see below.
Also fixes a forgotten requirements hike for cmake.
@terhorstd @jessica-mitchell I'd appreciate it if you could review this quickly as #2867 would benefit from it.