-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore_and_fire neuron model #2987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Melissa. Looks good to me. Just some minor things in the documentation.
Hi, thank you for the contribution! Is there any unit test that you might be able to add for the model? |
Hi Charl, maybe one could create one from this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mlober and @tomtetzlaff for your contribution!
I have a few changes requested: also the table is not rendering on Read the Docs and needs to be fixed up. See output: https://nest-simulator--2987.org.readthedocs.build/en/2987/models/ignore_and_fire.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jessica. This looks all very good to me. How can we fix the table? I copied the format from some other neuron model, iaf_psc_alpha, I think.
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Fix table
I fixed the table, it was only a misalignment of the second item in the second row |
…to ignore_and_fire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mlober @tomtetzlaff lgtm!
ping @clinssen :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
@tomtetzlaff Could you re-review so we can proceed to merging? |
This PR adds the ignore_and_fire neuron model of @tomtetzlaff. This neuron model was developed for benchmarking purposes with the goal of retaining constant activity levels while up- and down-scaling of the network. It sends out spikes in fixed time intervals, independent of the given input. It is handled like a regular neuron model by nest.
I suggest @tomtetzlaff and @jessica-mitchell as reviewers.