-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models no longer wrapped in SLI Module, model registration and thread-setting in managers revised #2990
Conversation
…ke it safe under change of number of threads.
@terhorstd @mlober Ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code compiles and runs nicely on my laptop. From what I can gather, the code and added documentation both look good to me (except for small typos - see comments).
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
@terhorstd I have now committed the changes discussed in person today and addressed the two comments above. I have also merged in master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK from my perspective. There is obvious need for refactoring in some places, but that should not clutter this PR.
👍
Big thanks to everyone involved!
Merged master past nest#2990
The main purpose of this PR (developed by @jougs) is to register node and connection models directly in the
ModelManager
without wrapping them in aSLIModule
. This change will allow implementation of extension module unloading at a later stage.As a side effect of this change, this PR also:
initialize()
andfinalize()
now have areset_kernel
argument (defaulttrue
) which controls if everything should be reset or only data structures adjusted to the new thread numbers. In the past, we actually reset more than we intended when just setting a new number of threads.