Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last mentions of C++11 as default #3033

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Remove last mentions of C++11 as default #3033

merged 4 commits into from
Dec 11, 2023

Conversation

heplesser
Copy link
Contributor

This PR updates the last remaining references to C++11 as our default language version to C++17 (since #2955).

It also removes obsolete Cmake platform files for Juron (decomissioned at the end of 2020).

@heplesser heplesser added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 5, 2023
@heplesser heplesser added this to In progress in Documentation via automation Dec 5, 2023
@heplesser heplesser added this to To do in Build system and CI via automation Dec 5, 2023
terhorstd
terhorstd approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting unrelated cleanup of ancient machine specific cmake files.
LGTM 👍

@terhorstd terhorstd added S: Normal Handle this with default priority and removed S: High Should be handled next labels Dec 11, 2023
@heplesser heplesser merged commit 098b06c into nest:master Dec 11, 2023
24 checks passed
Documentation automation moved this from In progress to Done Dec 11, 2023
Build system and CI automation moved this from To do to Done Dec 11, 2023
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
@heplesser heplesser deleted the fix11 branch April 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Build system and CI
  
Done
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @jessica-mitchell @terhorstd