Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve iaf_psc_alpha documentation #3034

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

heplesser
Copy link
Contributor

@heplesser heplesser commented Dec 6, 2023

This PR provides default and initial values in parameter tables and splits them into separate tables for parameters and state variables.

[edit] review docs here, especially for correct rendering of math and tables!

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 6, 2023
@heplesser heplesser added this to In progress in Documentation via automation Dec 6, 2023
models/iaf_psc_alpha.h Outdated Show resolved Hide resolved
Documentation automation moved this from In progress to Review Dec 14, 2023
Co-authored-by: Anno Christopher Kurth <44397333+ackurth@users.noreply.github.com>
@heplesser
Copy link
Contributor Author

@ackurth Thanks for spotting this, committed now.

@terhorstd terhorstd changed the title Further improve iaf_psc_alpha documentation Further improve iaf_psc_alpha documentation Dec 15, 2023
Copy link
Contributor

@ackurth ackurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@heplesser heplesser requested review from jessica-mitchell and removed request for jasperalbers December 19, 2023 20:26
@jessica-mitchell jessica-mitchell merged commit 2d4a72f into nest:master Dec 21, 2023
Documentation automation moved this from Review to Done Dec 21, 2023
@heplesser heplesser deleted the fix-doc branch April 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants