Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set buffer shrink limit to 20% by default (activates shrinking) and fix documentation #3035

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Set buffer shrink limit to 20% by default (activates shrinking) and fix documentation #3035

merged 2 commits into from
Dec 11, 2023

Conversation

heplesser
Copy link
Contributor

Based on results with the multiarea-model, activating shrinking of buffers seems very advantageous.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 6, 2023
@heplesser heplesser added this to In progress in Kernel via automation Dec 6, 2023
mlober
mlober approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@mlober mlober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this improvement.

@heplesser heplesser merged commit 8fe19e0 into nest:master Dec 11, 2023
24 checks passed
Kernel automation moved this from In progress to Done Dec 11, 2023
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
@heplesser heplesser deleted the fix_shrink_buffer branch April 24, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otcathatsya otcathatsya otcathatsya approved these changes

@mlober mlober mlober approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @otcathatsya @mlober