Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify clearing of spike buffers #3039

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Simplify clearing of spike buffers #3039

merged 3 commits into from
Dec 11, 2023

Conversation

mlober
Copy link
Contributor

@mlober mlober commented Dec 7, 2023

This PR fixes issue #2991 .

terhorstd
terhorstd requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes necessary to stay consistent with other loops and not copy elements of the vector.

nestkernel/event_delivery_manager.cpp Outdated Show resolved Hide resolved
nestkernel/event_delivery_manager.cpp Outdated Show resolved Hide resolved
@heplesser heplesser linked an issue Dec 11, 2023 that may be closed by this pull request
Superfluous clearing of containers #2991
Closed
mlober and others added 2 commits December 11, 2023 11:23
@mlober @terhorstd
Update nestkernel/event_delivery_manager.cpp
148534d 
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
@mlober @terhorstd
Update nestkernel/event_delivery_manager.cpp
0472169 
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 11, 2023
terhorstd
terhorstd approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@heplesser heplesser added this to In progress in Kernel via automation Dec 11, 2023
@heplesser heplesser merged commit ee575c7 into nest:master Dec 11, 2023
24 checks passed
Kernel automation moved this from In progress to Done Dec 11, 2023
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
Status: Done
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Superfluous clearing of containers
3 participants
@mlober @heplesser @terhorstd