Register only spikes actually sent with weight_recorder #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on<T>::send() must return whether they sent a spike or not.
heplesser
added
T: Bug
terhorstd
reviewed
Dec 11, 2023
JesusEV
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I applied these changes to a copy of the latest eprop_feature and applied the corresponding changes to eprop_synapse.h (returning false if the spike is to be ignored) and learning_signal_connection.h.
All verifications were successful.
By themselves, and all in all, the changes seem very appropriate
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
terhorstd
approved these changes
Dec 11, 2023
JesusEV
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, spikes would be registered with a
weight_recordereven if the spike was not transmitted to the target, e.g., by abernoulli_synapse. This PR changes allConnection<T>::send()methods to returntrueif they actually transmit a spike to the target node (calle();) andfalseotherwise.The PR also simplifies the code in the
bernoulli_synapse. Since this synapse model can only be used between normal nodes (not to/from devices), it will only receive events with multiplicity 1, allowing for significant simplification.@JesusEV @terhorstd I'd appreciate if you could fast-track this PR since e-prop work depends on it.