Rename the variable "Ca" in astrocyte_lr_1994 to "Ca_astro" #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
approved these changes
Feb 6, 2024
jessica-mitchell
added
S: Normal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is proposed to solve a conflict due to the same variable name "Ca" in astrocyte_lr_1994 and StructuralPlasticityNode.
We found that nest.GetStatus() and nest.GetDefaults() give wrong values of the calcium concentration (under the name "Ca") in astrocyte_lr_1994. This is because the parent class StructuralPlasticityNode also has a variable for calcium concentration under the same name. This conflict does not affect the simulations, as the underlying dynamics is not affected. Nevertheless, we would like change the variable name in astrocyte_lr_1994 to "Ca_astro" to avoid this conflict.
Corresponding changes have been made for all relevant kernel, documentation, and test files.